[Tarantool-patches] [PATCH luajit] Fix string.char() recording with no arguments.
Igor Munkin
imun at tarantool.org
Fri Jan 28 01:02:26 MSK 2022
Sergey,
On 28.01.22, Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch! Please consider my comments below.
>
> On 20.08.21, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > (cherry picked from commit dfa692b746c9de067857d5fc992a41730be3d99a)
> >
> > `string.char()` call without arguments yields an empty string. When JIT
> > machinery records the aforementioned call it doesn't handle this case.
> > Each recording fast function expects 1 result by default. Hence, when
>
> Typo: double space prior to "Hence".
Damn, I was looking at the old patch, but you've already fixed it in the
newer version. Sorry, feel free to ignore this nit.
>
<snipped>
>
> --
> Best regards,
> IM
--
Best regards,
IM
More information about the Tarantool-patches
mailing list