[Tarantool-patches] [PATCH 0/4] Split vote

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Jan 18 01:57:21 MSK 2022


On 16.01.2022 15:10, Konstantin Osipov wrote:
> * Vladislav Shpilevoy via Tarantool-patches <tarantool-patches at dev.tarantool.org> [22/01/15 03:52]:
>> Split vote handling in Raft, its usage in storage, and a bug fix found while
>> working on this in the first commit.
>>
>> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5285-raft-split-vote
>> Issue: https://github.com/tarantool/tarantool/issues/5285
> 
> While I don't mind this patch it is an unnecessary complication on
> top of the spec. To prevent the deteriorating effects on liveness
> from split vote one needs pre-voting, not split-vote detection.

I agree. I also don't like that patchset too much (not counting the first
commit, which fixes a crash). The pros are:

- can save some seconds in case of a split-vote;

- potentially can expose all the vote counts to the monitoring, not
  just own count.

Cons is - too much hassle in the code just for that.

Pre-voting on the other hand solves a different problem. Only slightly
related.


More information about the Tarantool-patches mailing list