[Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions
Igor Munkin
imun at tarantool.org
Wed Aug 31 18:34:39 MSK 2022
Sergey,
Thanks for your review!
On 18.08.22, Sergey Kaplun wrote:
> Hi, Igor!
>
> Thanks for the patch!
>
> LGTM in general, but have the same question as Sergey.
>
> On 15.08.22, Sergey Bronnikov wrote:
> > Igor, please see my comment below.
> >
> > On 11.08.2022 14:17, Igor Munkin wrote:
> > > Use out of source build configuration for LuaJIT testing jobs in all
> > > GitHub workflows. For this build type configuration unique subdirectory
> > > (using GitHub run ID) within runner temporary directory is used as a
> > > binary artefacts tree.
> > >
> > > Signed-off-by: Igor Munkin <imun at tarantool.org>
> > > ---
> > > .github/actions/environment/action.yml | 5 +++++
> > > .github/workflows/lint.yml | 3 ++-
> > > .github/workflows/linux-aarch64.yml | 6 +++++-
> > > .github/workflows/linux-x86_64-ninja.yml | 6 +++++-
> > > .github/workflows/linux-x86_64.yml | 7 ++++++-
> > > .github/workflows/macos-m1.yml | 6 +++++-
> > > .github/workflows/macos-x86_64.yml | 7 ++++++-
> > > 7 files changed, 34 insertions(+), 6 deletions(-)
> > >
<snipped>
> > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
> > > index 8c8dcff1..21d86764 100644
> > > --- a/.github/workflows/linux-aarch64.yml
> > > +++ b/.github/workflows/linux-aarch64.yml
> > > @@ -53,11 +53,15 @@ jobs:
> > > sudo apt -y update
> > > sudo apt -y install cmake gcc make perl
> > > - name: configure
> > > - run: cmake . ${{ matrix.CMAKEFLAGS }}
> > > + run: >
> > > + cmake -S . -B ${{ env.BUILDDIR }}
> > > + ${{ matrix.CMAKEFLAGS }}
> > > - name: build
> > > run: cmake --build . --parallel
> > > + working-directory: ${{ env.BUILDDIR }}
> > > - name: test
> > > run: cmake --build . --parallel --target test
> > > + working-directory: ${{ env.BUILDDIR }}
> >
> > 1. I don't get an idea to use current dir for CMake and specify a
> > working-directory in a job step.
> >
> > Why not "cmake --build ${{ env.BUILDDIR }}" as above?
>
> I don't get the idea too :).
I've answered to Sergey's thread.
>
<snipped>
>
> --
> Best regards,
> Sergey Kaplun
--
Best regards,
IM
More information about the Tarantool-patches
mailing list