[Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions
Sergey Kaplun
skaplun at tarantool.org
Thu Aug 18 12:58:35 MSK 2022
Hi, Igor!
Thanks for the patch!
LGTM in general, but have the same question as Sergey.
On 15.08.22, Sergey Bronnikov wrote:
> Igor, please see my comment below.
>
> On 11.08.2022 14:17, Igor Munkin wrote:
> > Use out of source build configuration for LuaJIT testing jobs in all
> > GitHub workflows. For this build type configuration unique subdirectory
> > (using GitHub run ID) within runner temporary directory is used as a
> > binary artefacts tree.
> >
> > Signed-off-by: Igor Munkin <imun at tarantool.org>
> > ---
> > .github/actions/environment/action.yml | 5 +++++
> > .github/workflows/lint.yml | 3 ++-
> > .github/workflows/linux-aarch64.yml | 6 +++++-
> > .github/workflows/linux-x86_64-ninja.yml | 6 +++++-
> > .github/workflows/linux-x86_64.yml | 7 ++++++-
> > .github/workflows/macos-m1.yml | 6 +++++-
> > .github/workflows/macos-x86_64.yml | 7 ++++++-
> > 7 files changed, 34 insertions(+), 6 deletions(-)
> >
> > diff --git a/.github/actions/environment/action.yml b/.github/actions/environment/action.yml
> > index 43323bc7..7fb2625f 100644
> > --- a/.github/actions/environment/action.yml
> > +++ b/.github/actions/environment/action.yml
<snipped>
> > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
> > index 8c8dcff1..21d86764 100644
> > --- a/.github/workflows/linux-aarch64.yml
> > +++ b/.github/workflows/linux-aarch64.yml
> > @@ -53,11 +53,15 @@ jobs:
> > sudo apt -y update
> > sudo apt -y install cmake gcc make perl
> > - name: configure
> > - run: cmake . ${{ matrix.CMAKEFLAGS }}
> > + run: >
> > + cmake -S . -B ${{ env.BUILDDIR }}
> > + ${{ matrix.CMAKEFLAGS }}
> > - name: build
> > run: cmake --build . --parallel
> > + working-directory: ${{ env.BUILDDIR }}
> > - name: test
> > run: cmake --build . --parallel --target test
> > + working-directory: ${{ env.BUILDDIR }}
>
> 1. I don't get an idea to use current dir for CMake and specify a
> working-directory in a job step.
>
> Why not "cmake --build ${{ env.BUILDDIR }}" as above?
I don't get the idea too :).
>
> >
> > test-tarantool-debug-w-GC64:
> > name: Tarantool Debug GC64:ON
> > diff --git a/.github/workflows/linux-x86_64-ninja.yml b/.github/workflows/linux-x86_64-ninja.yml
> > index 2877d2f6..72d56d54 100644
> > --- a/.github/workflows/linux-x86_64-ninja.yml
> > +++ b/.github/workflows/linux-x86_64-ninja.yml
<snipped>
> > name: Tarantool Debug GC64:OFF
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list