[Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling.
imun at tarantool.org
Fri May 14 13:31:13 MSK 2021
On 14.05.21, Sergey Ostanevich wrote:
> > Anyway, I see this is unclear to you, but everything is OK for Sergey.
> > Do I need to reword this part of commit message or even drop it?
> Just update the wording
> All LJ_TARGET_IOS uses in FFI sources are done with LJ_TARGET_ARM64 define being
> set, so we can simply replace these occurrences with LJ_TARGET_OSX.
Here is the final wording:
| FFI/ARM64/OSX: Fix vararg call handling.
| Thanks to Igor Munkin.
| (cherry picked from commit 521b367567dc5d91d7f9ae29c257998953e24e53)
| This patch fixes the issue introduced by commit
| 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203 ('OSX/iOS: Handle iOS simulator
| and ARM64 Macs.'). Within the mentioned commit LJ_TARGET_IOS define is
| set via Apple system header to enable several features (e.g. JIT and
| external unwinder) on ARM64 Macs, but its usage was not adjusted
| source-wide. This is done for FFI machinery within this commit.
| All LJ_TARGET_IOS uses in FFI sources are done with LJ_TARGET_ARM64
| define being set, so we can simply replace these occurrences with
| Igor Munkin:
| * added the description and the test for the problem
| Resolves tarantool/tarantool#6066
| Part of tarantool/tarantool#5629
| Relates to tarantool/tarantool#5983
| Reported-by: Nikita Pettik <korablev at tarantool.org>
| Reviewed-by: Sergey Kaplun <skaplun at tarantool.org>
| Reviewed-by: Sergey Ostanevich <sergos at tarantool.org>
| Signed-off-by: Igor Munkin <imun at tarantool.org>
> And it’s LGTM.
Also added your tag, thanks!
More information about the Tarantool-patches