[Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling.
Sergey Ostanevich
sergos at tarantool.org
Thu May 13 12:50:07 MSK 2021
Well, this doesn't help me with
> Since all LJ_TARGET_IOS usage is done with LJ_TARGET_ARM64 define being
> set, we can simply replace all occurrences with LJ_TARGET_OSX.
alongside with
> src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS
because if we apply first then the second will evaluate into
src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_OSX
which is always false?
Also there are still operable 32bit apps, including games, so iOS still supports 32bits - can this change cause problems? I believe Mike doesn’t care too much, so it can easily slip through.
Sergos
> On 13 May 2021, at 00:59, Igor Munkin <imun at tarantool.org> wrote:
>
> Sergos,
>
> On 12.05.21, Sergey Ostanevich wrote:
>> Hi!
>>
>> I can’t get this then
>>
>> src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS
>
> There is a verbose comment nearby[1] and the corresponding issue[2].
>
>>
>> How’s that survived in 2.1 branch?
>>
>> regards,
>> Sergos
>>
>>
>>> On 11 May 2021, at 14:31, Igor Munkin <imun at tarantool.org> wrote:
>>>
>>> Sergey,
>>>
>>> Thanks for your review!
>>>
>>> On 11.05.21, Sergey Kaplun wrote:
>>>> Hi, Igor!
>>>>
>>>> Thanks for the patch!
>>>> LGTM!
>>>
>>> Added your tag:
>>> | Reviewed-by: Sergey Kaplun <skaplun at tarantool.org>
>>>
>>> Also mentioned the issue[1]:
>>> | Resolves tarantool/tarantool#6066
>>>
>>>>
>>>> --
>>>> Best regards,
>>>> Sergey Kaplun
>>>
>>> [1]: https://github.com/tarantool/tarantool/issues/6066
>>>
>>> --
>>> Best regards,
>>> IM
>>
>
> [1]: https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L119
> [2]: https://github.com/LuaJIT/LuaJIT/issues/668
>
> --
> Best regards,
> IM
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20210513/30e6ff92/attachment.htm>
More information about the Tarantool-patches
mailing list