<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Well, this doesn't help me with<div class=""><br class=""></div><div class="">> <span style="font-family: Menlo-Regular;" class="">Since all LJ_TARGET_IOS usage is done with LJ_TARGET_ARM64 define being</span><br style="font-family: Menlo-Regular;" class=""><span style="font-family: Menlo-Regular;" class="">> set, we can simply replace all occurrences with </span><span style="font-family: Menlo-Regular;" class="">LJ_TARGET_OSX</span><span style="font-family: Menlo-Regular;" class="">.</span><br class=""><div><br class=""></div><div>alongside with</div><div><br class=""></div><div>> src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS</div><div><br class=""></div><div>because if we apply first then the second will evaluate into</div><div><br class=""></div><div>src/lj_prng.c:112:#if LJ_TARGET_OSX && !<span style="font-family: Menlo-Regular;" class="">LJ_TARGET_OSX</span></div><div><span style="font-family: Menlo-Regular;" class=""><br class=""></span></div><div><span style="font-family: Menlo-Regular;" class="">which is always false?</span></div><div><span style="font-family: Menlo-Regular;" class=""><br class=""></span></div><div><font face="Menlo-Regular" class="">Also there are still operable 32bit apps, including games, so iOS still supports 32bits - can this change cause problems? I believe Mike doesn’t care too much, so it can easily slip through.</font></div><div><font face="Menlo-Regular" class=""><br class=""></font></div><div><font face="Menlo-Regular" class="">Sergos</font></div><div><font face="Menlo-Regular" class=""><br class=""></font></div><div><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class="">On 13 May 2021, at 00:59, Igor Munkin <<a href="mailto:imun@tarantool.org" class="">imun@tarantool.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Sergos,<br class=""><br class="">On 12.05.21, Sergey Ostanevich wrote:<br class=""><blockquote type="cite" class="">Hi!<br class=""><br class="">I can’t get this then<br class=""><br class="">  src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS<br class=""></blockquote><br class="">There is a verbose comment nearby[1] and the corresponding issue[2].<br class=""><br class=""><blockquote type="cite" class=""><br class="">How’s that survived in 2.1 branch?<br class=""><br class="">regards,<br class="">Sergos<br class=""><br class=""><br class=""><blockquote type="cite" class="">On 11 May 2021, at 14:31, Igor Munkin <<a href="mailto:imun@tarantool.org" class="">imun@tarantool.org</a>> wrote:<br class=""><br class="">Sergey,<br class=""><br class="">Thanks for your review!<br class=""><br class="">On 11.05.21, Sergey Kaplun wrote:<br class=""><blockquote type="cite" class="">Hi, Igor!<br class=""><br class="">Thanks for the patch!<br class="">LGTM!<br class=""></blockquote><br class="">Added your tag:<br class="">| Reviewed-by: Sergey Kaplun <<a href="mailto:skaplun@tarantool.org" class="">skaplun@tarantool.org</a>><br class=""><br class="">Also mentioned the issue[1]:<br class="">| Resolves tarantool/tarantool#6066<br class=""><br class=""><blockquote type="cite" class=""><br class="">-- <br class="">Best regards,<br class="">Sergey Kaplun<br class=""></blockquote><br class="">[1]: <a href="https://github.com/tarantool/tarantool/issues/6066" class="">https://github.com/tarantool/tarantool/issues/6066</a><br class=""><br class="">-- <br class="">Best regards,<br class="">IM<br class=""></blockquote><br class=""></blockquote><br class="">[1]: <a href="https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L119" class="">https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L119</a><br class="">[2]: <a href="https://github.com/LuaJIT/LuaJIT/issues/668" class="">https://github.com/LuaJIT/LuaJIT/issues/668</a><br class=""><br class="">-- <br class="">Best regards,<br class="">IM<br class=""></div></div></blockquote></div><br class=""></div></body></html>