[Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Tue May 11 23:13:01 MSK 2021
Hi! Good job on the fixes, really!
Although function lbox_fiber_statof() still uses lua_pushinteger():
====================
static int
lbox_fiber_statof(struct fiber *f, void *cb_ctx, bool backtrace)
{
struct lua_State *L = (struct lua_State *) cb_ctx;
lua_pushinteger(L, f->fid); <<<<<<<<
lua_newtable(L);
====================
And cord_on_yield() still uses %d for fid:
====================
lua_pushfstring(L, "fiber %d is switched while running the"
" compiled code (it's likely a function with"
" a yield underneath called via LuaJIT FFI)",
fiber()->fid);
=========
lua_pushfstring(L, "fiber %d is switched while running GC"
" finalizer (i.e. __gc metamethod)",
fiber()->fid);
====================
Please, fix these places too.
More information about the Tarantool-patches
mailing list