[Tarantool-patches] [PATCH v3 10/10] say: fix CFORMAT specification
Cyrill Gorcunov
gorcunov at gmail.com
Tue May 11 00:58:33 MSK 2021
On Mon, May 10, 2021 at 08:40:34PM +0200, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> On 04.05.2021 17:58, Cyrill Gorcunov wrote:
> > The position of first argument to check from is 6, not 0.
> > Looks like our tests with CFORMAT was simply not working
> > since commit 7d12d66e67a1ce843a2712980f4d3ba04bc0d4f2.
>
> Please, in addition to the hash add the commit title in
> parentheses.
> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
Updated, thanks! I force pushed all updates.
More information about the Tarantool-patches
mailing list