[Tarantool-patches] [PATCH v2 luajit 29/30] test: disable PUC Lua hanging GC test

[Igor Munkin]

Sergos,

On 26.03.21, Sergey Ostanevich wrote:
> Can it be more relevant fix s/1000/n+1000/ for these two loops?
> 
> Although I start talking about an in-place fix, rather than a follow-up.

If you're talking about some constant value, then this solution is still
fragile: one can introduce a new Lua objects in Tarantool builtins and
the test is broken again. However, if you're talking about saving the
value yielded by "collectgarbage('count')" call after the series of
collectgarbage('collect') calls and use 1000 as a *relative* memory
growth, then it looks like a nice follow-up patch. Or Sergey can do it
in this series if he wants to.

> 
> LGTM.
> Sergos
> 
> > On 26 Mar 2021, at 10:43, Sergey Kaplun <skaplun at tarantool.org> wrote:
> > 
> > Tarantool has too many objects at start. `gcinfo()` result is always
> > greater than 1000 expected by the test. It leads to infinite loop in the
> > test.
> > 
> > This patch disables GC test leading to hanging for Tarantool binary.
> > 
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
> > ---
> > test/PUC-Lua-5.1-tests/gc.lua | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/test/PUC-Lua-5.1-tests/gc.lua b/test/PUC-Lua-5.1-tests/gc.lua
> > index 072bbe9..7f9880f 100644
> > --- a/test/PUC-Lua-5.1-tests/gc.lua
> > +++ b/test/PUC-Lua-5.1-tests/gc.lua
> > @@ -133,9 +133,12 @@ do
> >     local a = {}
> >   until gcinfo() > 1000
> >   collectgarbage"restart"
> > -  repeat
> > -    local a = {}
> > -  until gcinfo() < 1000
> > +  -- Tarantool has too many objects at start. `gcinfo()` result
> > +  -- is always greater than 1000.
> > +  -- LuaJIT: The test is disabled for Tarantool binary.
> > +  -- repeat
> > +  --   local a = {}
> > +  -- until gcinfo() < 1000
> > end
> > 
> > lim = 15
> > -- 
> > 2.31.0
> > 
> 

-- 
Best regards,
IM