[Tarantool-patches] [PATCH v2 luajit 29/30] test: disable PUC Lua hanging GC test

Igor Munkin imun at tarantool.org
Wed Mar 31 22:24:37 MSK 2021


Sergey,

Thanks for the patch! LGTM, except the nits below.

On 26.03.21, Sergey Kaplun wrote:
> Tarantool has too many objects at start. `gcinfo()` result is always
> greater than 1000 expected by the test. It leads to infinite loop in the
> test.
> 
> This patch disables GC test leading to hanging for Tarantool binary.

Minor: I propose the following rewording:
| This patch disables GC test leading to Tarantool binary hang.

> 
> Part of tarantool/tarantool#5845
> Part of tarantool/tarantool#4473
> ---
>  test/PUC-Lua-5.1-tests/gc.lua | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/test/PUC-Lua-5.1-tests/gc.lua b/test/PUC-Lua-5.1-tests/gc.lua
> index 072bbe9..7f9880f 100644
> --- a/test/PUC-Lua-5.1-tests/gc.lua
> +++ b/test/PUC-Lua-5.1-tests/gc.lua
> @@ -133,9 +133,12 @@ do
>      local a = {}
>    until gcinfo() > 1000
>    collectgarbage"restart"
> -  repeat
> -    local a = {}
> -  until gcinfo() < 1000
> +  -- Tarantool has too many objects at start. `gcinfo()` result

I dare to guess that you're talking about *alive* objects here. Please
mention this explicitly, if I'm right.

> +  -- is always greater than 1000.
> +  -- LuaJIT: The test is disabled for Tarantool binary.
> +  -- repeat
> +  --   local a = {}
> +  -- until gcinfo() < 1000
>  end
>  
>  lim = 15
> -- 
> 2.31.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list