[Tarantool-patches] [PATCH v2 luajit 00/30] Adapt PUC-Rio Lua 5.1 test suite

Igor Munkin imun at tarantool.org
Wed Mar 31 01:17:40 MSK 2021


Thanks for the series! I have two global comments for it:
* 'LuaJIT:' tag usage looks inconsistent: let's move all of them to the
  beginning of the related comments.
* Typo: s/LuaJIT's/LuaJIT/g.
  E.g. you never say "room's door" or "street's name". If you find the
  rule of possessives adjectives usage with inanimate subjects, please,
  share it with me.
* You use "PUC-Lua", "PUC Lua" and just "PUC" or "Lua" in commit
  subjects. Let's choose the single way referencing this Lua language
  implementation (and the corresponding test suite).

Best regards,

More information about the Tarantool-patches mailing list