[Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option
v.shpilevoy at tarantool.org
Tue Mar 30 01:19:10 MSK 2021
On 29.03.2021 23:57, Cyrill Gorcunov wrote:
> On Mon, Mar 29, 2021 at 11:54:45PM +0200, Vladislav Shpilevoy wrote:
>> Hi! Thanks for the fixes!
>> Please, don't try to rush and answer my comments immediately after
>> I send them. Even if they seem trivial. It won't speed the things
>> up, and you will simply miss something, as I told many times.
>> You still left 3 usages of 'is_paused == false', even though
>> I specifically said this is the most confusing one.
> I need to make sure the .is_paused is false, the assert(x == false)
> looks exactly what is needed. and we have similar code in our other
> tests, do you prefer assert(not x.is_paused) or what?
And there is much much much more tests using the booleans as they
are supposed to be used. Why do you need exactly 'false' as a literal?
More information about the Tarantool-patches