[Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option
gorcunov at gmail.com
Tue Mar 30 00:57:35 MSK 2021
On Mon, Mar 29, 2021 at 11:54:45PM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the fixes!
> Please, don't try to rush and answer my comments immediately after
> I send them. Even if they seem trivial. It won't speed the things
> up, and you will simply miss something, as I told many times.
> You still left 3 usages of 'is_paused == false', even though
> I specifically said this is the most confusing one.
I need to make sure the .is_paused is false, the assert(x == false)
looks exactly what is needed. and we have similar code in our other
tests, do you prefer assert(not x.is_paused) or what?
More information about the Tarantool-patches