[Tarantool-patches] [PATCH luajit 2/4] test: add skipcond on architectures for memprof

[Igor Munkin]

Sergey,

Thanks for the patch! Consider the couple of nits below regarding the
commit wording. Otherwise, LGTM.

Minor: It's hard to parse the patch subject IMHO. I propose the
following rewording:
| test: add arch-specific skipcond for memprof

On 24.05.21, Sergey Kaplun wrote:
> Memprof's tests fail for architectures different from x86 and x64,
> because memprof is not yet implemented for them.
> 
> This patch adds skip condition to corresponding test.

Typo: s/to corresponding/to the corresponding/.

> ---
>  test/tarantool-tests/misclib-memprof-lapi.test.lua | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua
> index b4d66509..4df9cfd8 100644
> --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua
> +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua
> @@ -1,3 +1,9 @@
> +-- Memprof is implemented only for x86 and x64 architectures.
> +require("utils").skipcond(
> +  jit.arch ~= "x86" or jit.arch ~= "x64",

Side note: Seen the bunch with the related fixes on the branch.

> +  jit.arch.." architecture is NIY for memprof"
> +)
> +
>  local tap = require("tap")
>  
>  local test = tap.test("misc-memprof-lapi")
> -- 
> 2.31.0
> 

-- 
Best regards,
IM