[Tarantool-patches] [PATCH resend v2 01/11] build: add Christian Hansen c-dt to the build

[Timur Safin]

: From: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
: Subject: Re: [PATCH resend v2 01/11] build: add Christian Hansen c-dt to the
: build
: 
: Hi! Thanks for the patch!
: 
: On 28.07.2021 12:34, Timur Safin wrote:
: > * Integrated chansen/c-dt parser as 3rd party module to the
: >   Tarantool cmake build process.
: > * Points to tsafin/c-dt instead iof original chansen/c-dt to
: 
: iof -> of. But is it even true? Below I see

Thanks!

: 
: 	url = https://github.com/tarantool/c-dt.git
: 
: not tsafin/c-dt.

We have relocated repository to Tarantool organization since then.

: 
: After build I get in git status this:
: 
: 	Changes not staged for commit:
: 	  (use "git add <file>..." to update what will be committed)
: 	  (use "git restore <file>..." to discard changes in working
: directory)
: 	  (commit or discard the untracked or modified content in submodules)
: 		modified:   third_party/c-dt (modified content, untracked
: content)
: 
: It says:
: 
: 	modified:   Makefile
: 
: and some untracked files:
: 
: 	CMakeFiles/
: 	cmake_install.cmake
: 	libcdt.a
: 
: Why is even Makefile added to the repository if we are
: using cmake anyway?

Yeah, sounds like a small cmake configuration annoyance. Cmake here generates their 
artifacts just right under sources, and not under ${CMAKE_CURRENT_BINARY_DIR}. Will
look how we could improve things, making it cleaner. 

Thanks,
Timur