[Tarantool-patches] [PATCH v2 2/3] sql: disallow explicit cast of VARBINARY to number

[Vladislav Shpilevoy]

Good job on the fixes!

On 27.07.2021 13:31, Mergen Imeev via Tarantool-patches wrote:
> Thank you for the review! My answers, diff and new patch below.
> 
> On 26.07.2021 23:12, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>
>> See 3 comments below.
>>
>> On 21.07.2021 17:10, Mergen Imeev via Tarantool-patches wrote:
>>> This patch removes explicit cast of VARBINARY values to numeric types.
>>>
>>> Part of #4470
>>> Closes #4772
>>> Closes #5852
>>
>> 1. You might need to add a changelog file.
>>
> I added in next commit, however, if you find it too general please let me know.
> I will make it more specific.

Yes, it looks too vague, a user won't be able to understand anything when
see it in the changelog. Lets add more specifics. That BOOL <-> numbers
was banned, and VARBINARY <-> numbers. And mention the bug that "sometimes
a string couldn't be cast to boolean even if it was a correct boolean".

After that LGTM and you can send it to a next reviewer.