[Tarantool-patches] [PATCH v8 3/6] limbo: gather promote tracking into a separate structure

Cyrill Gorcunov gorcunov at gmail.com
Thu Jul 29 09:40:55 MSK 2021


On Thu, Jul 29, 2021 at 12:07:44AM +0200, Vladislav Shpilevoy wrote:
> > 
> > The key moment here is the locking we use for terms tracking,
> > note the locking is not covering the whole limbo thus better
> > to keep the lock itself inside the structure it protects I think.
> 
> Yes, the struct it protects is the limbo. Part of. I see no sense
> to extract the members you protect into a new struct just because
> only they are protected.

It doesn't protect limbo itself, the entries are added to the queue
without taking a lock (in contrast with cbus), so I completely don't
agree with your arguments. Still I'm fine to move these members back
to the limbo structure as you prefer. Will do.


More information about the Tarantool-patches mailing list