[Tarantool-patches] [PATCH 01/20] net.box: fix console connection breakage when request is discarded

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Jul 29 01:49:17 MSK 2021


Thanks for the patch!

The commit is different from what I see on the branch. Please,
try to keep the email thread up to date. Or do you prefer the
github PRs now?

Here and in other emails I will use the commits I see on the
branch.

> diff --git a/test/box/net.box_discard_console_request.result b/test/box/net.box_discard_console_request.result
> new file mode 100644
> index 000000000..e8da50a2f
> --- /dev/null
> +++ b/test/box/net.box_discard_console_request.result

For bug tests we now use name format `gh-####-your-description`.
The other names different from this format are outdated and should
not be used as an example.
https://github.com/tarantool/tarantool/wiki/Code-review-procedure#testing

The rest of the commit LGTM.


More information about the Tarantool-patches mailing list