[Tarantool-patches] [PATCH v8 3/6] limbo: gather promote tracking into a separate structure

Cyrill Gorcunov gorcunov at gmail.com
Thu Jul 29 00:57:36 MSK 2021


On Wed, Jul 28, 2021 at 11:34:43PM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> On 26.07.2021 17:34, Cyrill Gorcunov via Tarantool-patches wrote:
> > It is needed to introduce ordered promote related data
> > modifications in next patch.
> 
> Why do you need this new struct? While I like the new names
> (the old promote_greatest_term was super long), I don't see
> any motivation to extract the members into a new struct.
> It is still used only inside of the limbo as a member.
> 
> I suppose this might be a leftover from the old versions of
> the patchset. Please, try to keep these members inside of
> the limbo like they were.

The key moment here is the locking we use for terms tracking,
note the locking is not covering the whole limbo thus better
to keep the lock itself inside the structure it protects I think.

	Cyrill


More information about the Tarantool-patches mailing list