[Tarantool-patches] [PATCH v2 08/10] test: support tarantool cli in lua-Harness
Sergey Kaplun
skaplun at tarantool.org
Wed Jul 28 21:50:18 MSK 2021
On 28.07.21, Sergey Kaplun via Tarantool-patches wrote:
> Hi, Maxim!
>
> Thanks for the patch and fixes!
>
> LGTM, except a few nits regarding to the commit message.
>
> On 26.07.21, Максим Корякшин wrote:
> >
> > Thanks for the review, Igor!
> > Here is the new commit message, considering your comments:
> > =================================================
> > test: support tarantool cli in lua-Harness
> >
> > The patch[1] from lua-Harness suite adjusts some checks in
>
> Typo: s/from lua-Harness suite/the from lua-Harness suite/
Brr, typo in typo: "from the lua-Harness suite", of course.
>
> > lua-Harness tests, so they are compatible with Tarantool now.
> >
> > As a result, the introduced assertion for Tarantool error message fails
> > on MacOS, since getopt_long(3) yields the error message without single
> > quotes wrapping the flag. Hence, this commit also includes fix for that
>
> Typo: s/fix/the fix/
>
> > from patch[2] in the trunk.
>
> Typo: s/patch/the patch/
>
> >
> > [1]: https://framagit.org/fperrad/lua-Harness/-/commit/1da5b1b
> > [2]: https://framagit.org/fperrad/lua-Harness/-/commit/a0532c5
> >
> > Part of tarantool/tarantool#5970
> > Part of tarantool/tarantool#4473
> >
> > =================================================
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list