[Tarantool-patches] [PATCH v2 04/10] test: refactor with _retrieve_progname
Sergey Kaplun
skaplun at tarantool.org
Tue Jul 27 12:27:22 MSK 2021
Hi, Max!
Thanks for the patch!
LGTM, except several nitpicks regarding the commit message:
===================================================================
test: refactor with _retrieve_progname
The patch[1] from lua-Harness suite fixes the same issue commit
Typo: /from lua-Harness suite/from the lua-Harness suite/
Typo: /commit/as the commit/
837688590919fcf8de47ef90479fd2a640c8fddc ('test: adjust lua-Harness
suite to CMake machinery') does except the single difference:
`get_lua_binary_name()` is called `_retrieved_progname()`. As a result
of this patch the function is renamed to follow the original naming.
[1]: https://framagit.org/fperrad/lua-Harness/-/commit/1be25a8
Part of tarantool/tarantool#5970
Part of tarantool/tarantool#4473
===================================================================
On 26.07.21, Igor Munkin wrote:
> Max,
>
> Thanks for the fixes! LGTM.
>
> --
> Best regards,
> IM
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list