[Tarantool-patches] [PATCH v1 1/1] sql: bit-wise operations now accepts only UNSIGNED

Mergen Imeev imeevma at tarantool.org
Tue Jul 27 12:10:58 MSK 2021


Thank you for the review! My answer below.

On Mon, Jul 26, 2021 at 11:54:46PM +0200, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> On the branch I see 2 commits on top of the master. Did you
> send the first commit anywhere? This one - "sql: clear MEM
> only if necessary". I am not sure it is needed or even better
> than it was before, because it adds a branch.
I rebased this patch to current master and removed "sql: clear MEM ..." commit.
That commit was to make simpler usage of mem_set_*() functions. However, later
I understood that it is completely wrong, and even it was right it is not better
than it is now.


More information about the Tarantool-patches mailing list