[Tarantool-patches] [PATCH v2 07/10] test: backport lua-Harness directory detection

Igor Munkin imun at tarantool.org
Mon Jul 26 00:12:11 MSK 2021


Max,

Thanks for the patch! LGTM, except the three typos.

On 20.07.21, Maxim Kokryashkin wrote:
> The patch[1] from lua-Harness fixes the same issue commit

Typo: The link is missing.

> 789820aac7cecc3b5ae394aadc12a5ec25b68121('test: fix directory detection

Typo: Space is missing after the commit hash.

> in lua-Harness suite') does, but it also works on Windows, so the
> mentioned commit can be supreseded by that patch.

Typo: s/supreseded/superseded/.

> 
> Part of tarantool/tarantool#5970
> Part of tarantool/tarantool#4473
> ---
>  test/lua-Harness-tests/314-regex.t | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

<snipped>

> -- 
> 2.32.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list