[Tarantool-patches] [PATCH v1 2/3] sql: fix uuid behaviour in least() and greatest()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Jul 8 00:42:16 MSK 2021


Thanks for the patch!

> diff --git a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua
> index d8fa700ea..8872f9f23 100755
> --- a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua
> +++ b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua
> @@ -13,4 +15,21 @@ test:do_execsql_test(
>          '11111111-1111-1111-1111-111111111111'
>      })
>  
> +-- Make sure that functions greatest() and least() can properly work with uuid.
> +test:do_execsql_test(
> +    "gh-6164-2",
> +    [[
> +        SELECT GREATEST(true, 1, x'33', cast('11111111-1111-1111-1111-111111111111' as uuid), 1e10);

Please, try to remain inside 80 symbols line width limit. The same below.

> +    ]], {
> +        uuid
> +    })
> +
> +test:do_execsql_test(
> +    "gh-6164-3",
> +    [[
> +        SELECT LEAST(true, 1, x'33', cast('11111111-1111-1111-1111-111111111111' as uuid), 1e10);
> +    ]], {
> +        true
> +    })
> +
>  test:finish_test()
> 


More information about the Tarantool-patches mailing list