[Tarantool-patches] [PATCH v1 1/3] sql: introduce uuid to quote()

[Vladislav Shpilevoy]

Hi! Thanks for the patch!

> diff --git a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua
> new file mode 100755
> index 000000000..d8fa700ea
> --- /dev/null
> +++ b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua

1. The test runs 2 times with 2 engines. Please, make it work only
once. It does not depend on an engine anyway.

> @@ -0,0 +1,16 @@
> +#!/usr/bin/env tarantool
> +local test = require("sqltester")
> +test:plan(1)
> +
> +box.execute([[select quote(cast('11111111-1111-1111-1111-111111111111' as uuid));]])

2. Why do you need this select? Isn't it exactly the same as the SELECT below?

> +
> +-- Make sure that function quote() can work with uuid.
> +test:do_execsql_test(
> +    "gh-6164-1",
> +    [[
> +        SELECT quote(cast('11111111-1111-1111-1111-111111111111' as uuid));
> +    ]], {
> +        '11111111-1111-1111-1111-111111111111'
> +    })
> +
> +test:finish_test()