[Tarantool-patches] [PATCH luajit] gdb: fix misalignment in lj-stack for LJ_GC64

Igor Munkin imun at tarantool.org
Wed Jul 7 21:35:49 MSK 2021


Misha,

Thanks for the new patch! It LGTM, but I have two side notes for the
further series.

1. This is the second attempt to fix #5876. Hence, as it is mentioned in
our guidelines[1], in addition to 'luajit' prefix, you need to add 'v2'
prefix too for the convenience.
2. Do not forget adding the issue link the same way you do for the
remote branch.

These are not critical nits, but such minor "whistles" make maintainer's
life better!

[1]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list