[Tarantool-patches] [PATCH vshard 4/6] config: introduce master 'auto' replicaset option

[Oleg Babin]

Thanks for your change. LGTM.

On 03.07.2021 00:32, Vladislav Shpilevoy wrote:
> Hi! Thanks for the extensive review!
>
>>> +local function check_replicaset_master(master, ctx)
>>> +    if not lutil.version_is_at_least(1, 10, 0) then
>>> +        error('Only versions >= 1.10 support master discovery')
>>> +    end
>> If we talk about "is_async" netbox option. We should check 1.10.1:
>>
>> https://github.com/tarantool/tarantool/commit/0f686829a89b87d4f8d10fd25d4acfdea9b3dc60#diff-1e545a3af3d3592423eff523367e962e18f7eda45c2f9bef6994a254f6044d70
>>
>> There is a gap between 1.10.0 and 1.10.1 when there is no is_async.
> Good call. It is easy to fix so I did it:
>
> ====================
> @@ -22,8 +22,9 @@ local function check_replica_master(master, ctx)
>   end
>   
>   local function check_replicaset_master(master, ctx)
> -    if not lutil.version_is_at_least(1, 10, 0) then
> -        error('Only versions >= 1.10 support master discovery')
> +    -- Limit the version due to extensive usage of netbox is_async feature.
> +    if not lutil.version_is_at_least(1, 10, 1) then
> +        error('Only versions >= 1.10.1 support master discovery')
>       end
>       if master ~= 'auto' then
>           error('Only "auto" master is supported')