[Tarantool-patches] [PATCH vshard 4/6] config: introduce master 'auto' replicaset option

[Oleg Babin]

Thanks for your patch. LGTM. One nit below.

On 02.07.2021 01:09, Vladislav Shpilevoy wrote:
> The new option will enable auto-search for master on the marked
> replicasets.
>
> Part of #75
> ---
>
> +local function check_replicaset_master(master, ctx)
> +    if not lutil.version_is_at_least(1, 10, 0) then
> +        error('Only versions >= 1.10 support master discovery')
> +    end

If we talk about "is_async" netbox option. We should check 1.10.1:

https://github.com/tarantool/tarantool/commit/0f686829a89b87d4f8d10fd25d4acfdea9b3dc60#diff-1e545a3af3d3592423eff523367e962e18f7eda45c2f9bef6994a254f6044d70

There is a gap between 1.10.0 and 1.10.1 when there is no is_async.

Feel free to ignore. I don't believe it will happen ever.

> +    if master ~= 'auto' then
> +        error('Only "auto" master is supported')
> +    end
> +end
> +