[Tarantool-patches] [PATCH v5 01/52] sql: enhance vdbe_decode_msgpack_into_mem()

[Mergen Imeev]

Thank you for the review!

On Wed, Apr 14, 2021 at 01:22:34AM +0200, Vladislav Shpilevoy wrote:
> Good job on the patch!
> 
> On 13.04.2021 14:01, Mergen Imeev wrote:
> > Thank you for the review! I'a sorry to ask you so late, but could you look at
> > new version of the patch? It was decided that this patch should be pushed to
> > 2.6 and 2.7 along with master. Only this patch of the patch-set.
> 
> I think the entire patchset must be pushed to all versions. Otherwise you are
> going to have hard time to cherry-pick anything from the master branch.
> 
I will ask about this tomorrow.

> Additionally, what about
> 
> 	sql: rework vdbe_decode_msgpack_into_mem()
> 
> ? It also fixes a bug.
> 
True. I knew that it fixes a bug, but didn't thouth about the fact, that it
possibly won't be pushed to 2.6 and 2.7. For now I do not know what to do about
this patch. I will ask about this also.

> On the branch I see the entire patchset, not just this commit. Is it
> intended?
> 
Yes, it is. I did not split this commit from patch-set, for now.

> 
> This commit LGTM.