[Tarantool-patches] [PATCH v5 01/52] sql: enhance vdbe_decode_msgpack_into_mem()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Apr 14 02:22:34 MSK 2021


Good job on the patch!

On 13.04.2021 14:01, Mergen Imeev wrote:
> Thank you for the review! I'a sorry to ask you so late, but could you look at
> new version of the patch? It was decided that this patch should be pushed to
> 2.6 and 2.7 along with master. Only this patch of the patch-set.

I think the entire patchset must be pushed to all versions. Otherwise you are
going to have hard time to cherry-pick anything from the master branch.

Additionally, what about

	sql: rework vdbe_decode_msgpack_into_mem()

? It also fixes a bug.

On the branch I see the entire patchset, not just this commit. Is it
intended?


This commit LGTM.


More information about the Tarantool-patches mailing list