[Tarantool-patches] [PATCH v2 luajit 11/30] test: adapt getlocal PUC test for vararg func

Igor Munkin imun at tarantool.org
Tue Apr 6 23:40:42 MSK 2021


On 06.04.21, Igor Munkin wrote:
> Sergey,
> 
> On 01.04.21, Sergey Kaplun wrote:
> > Igor,
> > 
> > Thanks for the review!
> > 
> > On 31.03.21, Igor Munkin wrote:
> > > Sergey,
> > > 
> > > Thanks for the patch! I can't understand why this patch is separated
> > > from the previous one. Could you provide a rationale for this, please?
> > > BTW as we discussed before: s/Closes/Resolves/, considering your changes
> > > on the branch. Also consider the comments below.
> > 
> > The root reason of the previous patch is about counting of local
> > variable in caller. Here this local variable is used for counting
> > arguments amount.
> 
> OK, now I get it. Let's then squash 11 and 16 patches, since they solves

It's a typo: s/16/20/ while reading please.

> the one problem and leave 10 as is, since it fixes a different one. BTW,
> I'm even fine if you leave everything as is. So, here is my LGTM and
> feel free to adjust these patches on your own.
> 
> > 
> 
> <snipped>
> 
> > 
> > -- 
> > Best regards,
> > Sergey Kaplun
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list