[Tarantool-patches] [PATCH v2 luajit 12/30] test: adapt PUC Lua test with count hooks
Sergey Kaplun
skaplun at tarantool.org
Thu Apr 1 14:42:45 MSK 2021
Igor,
Thanks for the review!
On 31.03.21, Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch! LGTM, except the single nit below.
>
> On 26.03.21, Sergey Kaplun wrote:
> > LuaJIT does not check hooks at traces without defined
> > -DLUAJIT_ENABLE_CHECKHOOK. For more information see <src/lj_record.c>
> > or commit 6bce6b118eeb2bb7f36157de158e5cccf0ea68e5 (Add compile-time
> > option LUAJIT_ENABLE_CHECKHOOK. Disabled by default.).
> >
> > This patch adapts these tests for LuaJIT by disabling JIT while testing
> > count hooks.
> >
> > Closes tarantool/tarantool#5701
>
> As we discussed before: s/Closes/Resolves/.
Fixed.
>
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
>
> <snipped>
>
> > --
> > 2.31.0
> >
>
> --
> Best regards,
> IM
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list