[Tarantool-patches] [PATCH v2 luajit 28/30] test: disable PUC Lua test checking -h option

Sergey Kaplun skaplun at tarantool.org
Fri Apr 2 11:39:05 MSK 2021


Igor,

Thanks for the review!

On 31.03.21, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM, except the nits below. I see you added FIXME
> here, so we can uncomment the test, if we separate LuaJIT regular
> testing from Tarantool CI sometime...

Yep, or will change Tarantool's behaviour.

> 
> On 26.03.21, Sergey Kaplun wrote:
> > Tarantool returns zero status at exit with -h option, unlike Lua or
> > LuaJIT does.
> > 
> > This patch disables test checking returning status, when binary
> 
> Typo: s/disables test/disables the test/.
> Typo: s/checking returning status/checking the exit code/.

Fixed.

> 
> > runs with -h option.
> > 
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
> > ---
> 
> <snipped>
> 
> > -- 
> > 2.31.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list