[Tarantool-patches] [PATCH v2 luajit 27/30] test: disable PUC Lua test for checking arg layout

Sergey Kaplun skaplun at tarantool.org
Fri Apr 2 11:35:21 MSK 2021


Igor,

Thanks for the review!

On 31.03.21, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM, except the single nit. I see you added FIXME
> here, so we can uncomment the test, if we separate LuaJIT regular
> testing from Tarantool CI sometime...

Yes, or even will make their behaviour the same.

> 
> On 26.03.21, Sergey Kaplun wrote:
> > Unlike LuaJIT, Tarantool doesn't store the given CLI flags in `arg`,
> > so the table has the following layout:
> > * arg[-1] -- the binary name
> > * arg[0]  -- the script name
> > * arg[N]  -- the script argument for all N in [1, #arg]
> > 
> > This patch disables test checking `arg` layout by negative indexes.
> 
> Typo: s/disables test/disables the test/.

Fixed.

> 
> > 
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
> 
> <snipped>
> 
> > -- 
> > 2.31.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list