[Tarantool-patches] [PATCH v1 0/2] sql: ignore \0 in string passed to user function

Kirill Yukhin kyukhin at tarantool.org
Fri Apr 2 10:55:07 MSK 2021


Hello,

On 30 мар 14:21, Mergen Imeev via Tarantool-patches wrote:
> Currently, string passed to user-defined function from SQL can be cropped in
> case it contains '\0'. This patch-set fixes this behaviour.
> 
> https://github.com/tarantool/tarantool/issues/5938
> https://github.com/tarantool/tarantool/tree/imeevma/gh-5938-wrong-string-length
> 
> Mergen Imeev (2):
>   sql: ignore \0 in string passed to C-function
>   sql: ignore \0 in string passed to Lua-function
> 
>  src/box/sql/func.c                            |  6 ++-
>  test/CMakeLists.txt                           |  1 +
>  test/sql-tap/CMakeLists.txt                   |  2 +
>  test/sql-tap/gh-5938-wrong-string-length.c    | 42 +++++++++++++++++
>  .../gh-5938-wrong-string-length.test.lua      | 45 +++++++++++++++++++
>  5 files changed, 94 insertions(+), 2 deletions(-)
>  create mode 100644 test/sql-tap/CMakeLists.txt
>  create mode 100644 test/sql-tap/gh-5938-wrong-string-length.c
>  create mode 100755 test/sql-tap/gh-5938-wrong-string-length.test.lua

LGTM.

I've checked your patchset into 2.6, 2.7 and master.

--
Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list