[Tarantool-patches] [PATCH v2 luajit 19/30] test: remove assert for string.gfind check

Sergey Kaplun skaplun at tarantool.org
Fri Apr 2 10:05:23 MSK 2021


Igor,

Thanks for the review!

On 31.03.21, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM, except the single nit.
> 
> On 26.03.21, Sergey Kaplun wrote:
> > In Lua 5.1 function `string.gfind()` was renamed to `string.gmatch()`.
> > You can use it if Lua 5.1 is built with compile-time option
> > `-DLUA_COMPAT_GFIND`.
> > This built-in is removed from LuaJIT.
> 
> Please mention the patch[1] where this builtin is removed.

Done.

> 
> > 
> > This patch removes test checking that `string.gfind()` and
> > `string.gmatch() is the same function.
> > 
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
> > ---
> >  test/PUC-Lua-5.1-tests/pm.lua | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> 
> <snipped>
> 
> > -- 
> > 2.31.0
> > 
> 
> [1]: https://github.com/tarantool/luajit/commit/de5568e
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list