[Tarantool-patches] [PATCH v2 luajit 10/30] test: adapt test for debug.setlocal in Lua suite

[Sergey Kaplun]

Igor,

Thanks for the review!

On 31.03.21, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM, considering your changes on the branch. Also
> consider the comments below.
> 
> On 26.03.21, Sergey Kaplun wrote:
> > LuaJIT: Lua 5.1 interprets `...` in the vararg functions like
> 
> Looks like you just copied the comment below. There is no need for
> 'LuaJIT:' here.
> 
> > an additional first argument unlike LuaJIT does.
> > This behaviour is extension is from Lua 5.2.
> 
> Typo: s/is extension is/is extension/.
> 
> > 
> > This patch adapted test considering LuaJIT's and Lua 5.2 behaviour.
> 
> Side note: Here it is -- you wrote LuaJIT's but Lua 5.2 (neither Lua's
> 5.2 nor Lua 5.2's). How come?
> 
> > The test is adapted like it done in Lua 5.2 test suite taken from
> > https://www.lua.org/tests/lua-5.2.0-tests.tar.gz.
> > 
> > Closes tarantool/tarantool#5694
> 
> As we discussed before: s/Closes/Resolves/.
> 
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
> > ---

The new version of the commit message:
===================================================================
test: adapt test for debug.setlocal in Lua suite

Lua 5.1 interprets `...` in the vararg functions like an additional
local argument unlike LuaJIT does. This behaviour is extension from
Lua 5.2.

This patch adapted test considering behaviour of LuaJIT and Lua 5.2.
The test is adapted like it done in Lua 5.2 test suite taken from
https://www.lua.org/tests/lua-5.2.0-tests.tar.gz.

Part of tarantool/tarantool#5694
Part of tarantool/tarantool#5845
Part of tarantool/tarantool#4473
===================================================================

> 
> <snipped>
> 
> > -- 
> > 2.31.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun