[Tarantool-patches] [PATCH v2 luajit 08/30] test: disable JIT for GC step counting tests

[Sergey Kaplun]

Igor,

Thanks for the review!

On 31.03.21, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM, except the nits below.
> 
> I propose the following rewording for commit subject:
> | test: disable JIT for the tests counting GC steps

Thanks, applied!

> 
> On 26.03.21, Sergey Kaplun wrote:
> > JIT compilation can unpredictable allocate or reference objects (or
> 
> Typo: s/unpredictable/unpredictably/.

Fixed, thanks.

> 
> > traces itself). So, the amount of GC steps can vary from run to run.
> > 
> > This patch disables JIT machinery, if it is enabled, for stable GC
> > results.
> > 
> > Part of tarantool/tarantool#5845
> > Part of tarantool/tarantool#4473
> > ---
> >  test/PUC-Lua-5.1-tests/gc.lua | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/test/PUC-Lua-5.1-tests/gc.lua b/test/PUC-Lua-5.1-tests/gc.lua
> > index 86a9f75..072bbe9 100644
> > --- a/test/PUC-Lua-5.1-tests/gc.lua
> > +++ b/test/PUC-Lua-5.1-tests/gc.lua
> > @@ -108,11 +108,21 @@ local function dosteps (siz)
> >    return i
> >  end
> >  
> > +-- LuaJIT: JIT compilation can unpredictable allocate or reference
> 
> Typo: s/unpredictable/unpredictably/.

Fixed.

> 
> > +-- objects (or traces itself). Disable it if necessary for
> > +-- this chunk for stable GC results.
> 
> <snipped>
> 
> > -- 
> > 2.31.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun