[Tarantool-patches] [PATCH v2 2/2] lua: abort trace recording on fiber yield

[Igor Munkin]

Sergos,

Thanks for your review!

On 29.09.20, Sergey Ostanevich wrote:
> Hi!
> 
> Thanks for the patch!
> 
> I wonder how many tests are failing due to #4819 and are they covered 
> with skip conditions?

I know only three: this one and two from LuaJIT tests (for FFI sandwich
and flushing trace while running one).

> Also, how will we fix all those tests after FreeBSD fixup?

Just remove this skipcond file. The problem is JIT fails to assemble the
recorded trace, so the mcode is not generated and the "desired" platform
panic doesn't occur. When the issue is fixed, the test should be fine.

> 
> The patchset is LGTM to me.

Added your tag:
| Reviewed-by: Sergey Ostanevich <sergos at tarantool.org>

> 
> Regards,
> Sergos
> 
> On 28 сен 20:45, Igor Munkin wrote:
> > Meh, the last one (I hope): I forgot there are the issues with JIT on
> > FreeBSD[1]. So I added skipcond file for the newly added test:
> > 

<snipped>

> > 
> > [1]: https://github.com/tarantool/tarantool/issues/4819
> > 
> > -- 
> > Best regards,
> > IM

-- 
Best regards,
IM