[Tarantool-patches] [PATCH v2 2/2] lua: abort trace recording on fiber yield

[Sergey Ostanevich]

Hi!

Thanks for the patch!

I wonder how many tests are failing due to #4819 and are they covered 
with skip conditions?
Also, how will we fix all those tests after FreeBSD fixup?

The patchset is LGTM to me.

Regards,
Sergos

On 28 сен 20:45, Igor Munkin wrote:
> Meh, the last one (I hope): I forgot there are the issues with JIT on
> FreeBSD[1]. So I added skipcond file for the newly added test:
> 
> ================================================================================
> 
> diff --git a/test/app-tap/gh-1700-abort-recording-on-fiber-switch.skipcond b/test/app-tap/gh-1700-abort-recording-on-fiber-switch.skipcond
> new file mode 100644
> index 000000000..2a2ec4d97
> --- /dev/null
> +++ b/test/app-tap/gh-1700-abort-recording-on-fiber-switch.skipcond
> @@ -0,0 +1,7 @@
> +import platform
> +
> +# Disabled on FreeBSD due to #4819.
> +if platform.system() == 'FreeBSD':
> +    self.skip = 1
> +
> +# vim: set ft=python:
> 
> ================================================================================
> 
> [1]: https://github.com/tarantool/tarantool/issues/4819
> 
> -- 
> Best regards,
> IM