[Tarantool-patches] [PATCH v4 07/12] txm: introduce memtx_story

[Nikita Pettik]

On 22 Sep 20:51, Aleksandr Lyapunov wrote:
> Thank for the review.
> Most is fixed, see my replies below.
> 
> On 15.09.2020 17:33, Nikita Pettik wrote:
> 
> > > +int
> > > +memtx_tx_track_read(struct txn *txn, struct space *space, struct tuple *tuple)
> > > +{
> > > +	if (tuple == NULL)
> > > +		return 0;
> > > +	if (txn == NULL)
> > > +		return 0;
> > > +	if (space == NULL)
> > > +		return 0;
> > Space seems to be always != NULL. If so, let's replace it with an assertion.
> I found out that in iterators the space can be NULL. I'm not sure
> why, but I happens without my patch set. I just accepted it.
>

Hm, sounds strange. I've replaced this check with an assertion and all tests
seem to pass..