[Tarantool-patches] [PATCH v4 07/12] txm: introduce memtx_story

Aleksandr Lyapunov alyapunov at tarantool.org
Tue Sep 22 20:51:16 MSK 2020


Thank for the review.
Most is fixed, see my replies below.

On 15.09.2020 17:33, Nikita Pettik wrote:

>> +int
>> +memtx_tx_track_read(struct txn *txn, struct space *space, struct tuple *tuple)
>> +{
>> +	if (tuple == NULL)
>> +		return 0;
>> +	if (txn == NULL)
>> +		return 0;
>> +	if (space == NULL)
>> +		return 0;
> Space seems to be always != NULL. If so, let's replace it with an assertion.
I found out that in iterators the space can be NULL. I'm not sure
why, but I happens without my patch set. I just accepted it.



More information about the Tarantool-patches mailing list