[Tarantool-patches] [PATCH 2/2] lua: add missing LuaJIT export symbols

Sergey Kaplun skaplun at tarantool.org
Mon Oct 19 07:57:15 MSK 2020


Igor,

Thanks for the review! I've updated commit message considering your
comment here. Branch is force pushed.

On 18.10.20, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM, except a single nit.
> 
> On 17.10.20, Sergey Kaplun wrote:
> > Since LuaJIT provides public C API symbols that are used in the final
> > executable, the linker may not just throw it away.
> > Nevertheless for future compatibility all symbols from LuaJIT public API
> > should be additionaly added at exports.h file.
> > 
> > Follows up tarantool/tarantool#5187
> 
> Minor: You don't need to use full repo reference here.
> 
> > ---
> >  src/exports.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> 
> <snipped>
> 
> > -- 
> > 2.28.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list