[Tarantool-patches] [PATCH 2/2] lua: add missing LuaJIT export symbols
Igor Munkin
imun at tarantool.org
Sun Oct 18 21:43:17 MSK 2020
Sergey,
Thanks for the patch! LGTM, except a single nit.
On 17.10.20, Sergey Kaplun wrote:
> Since LuaJIT provides public C API symbols that are used in the final
> executable, the linker may not just throw it away.
> Nevertheless for future compatibility all symbols from LuaJIT public API
> should be additionaly added at exports.h file.
>
> Follows up tarantool/tarantool#5187
Minor: You don't need to use full repo reference here.
> ---
> src/exports.h | 2 ++
> 1 file changed, 2 insertions(+)
>
<snipped>
> --
> 2.28.0
>
--
Best regards,
IM
More information about the Tarantool-patches
mailing list