[Tarantool-patches] [PATCH 1/1] iproto: show real port in logs and box.info.listen

Serge Petrenko sergepetrenko at tarantool.org
Thu Mar 19 13:24:20 MSK 2020


> 19 марта 2020 г., в 01:38, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> написал(а):
> 
> Thanks for the review!
> 
> On 18/03/2020 19:18, Serge Petrenko wrote:
>> Hi! Thanks for the patch!
>> Alexander asked me to do the 2nd review.
>> 
>> The patch LGTM.
>> 
>> Sorry for nitpicking,  but looks like your changelog request has a typo in it:
>>> @ChangeLog
>>> - box.info.listen - new record in box.info <http://box.info>, which shows a
>>>  real port when bound to port 0. For example, if box.cfg
>>>  'listen' parameter was set to '127.0.0.1:0', box.info.listen
>>>  will show '127.0.0.1:<real port > 0>' (gh-4620).
>> just <real port>, without 0>, right?
> 
> Nope, I meant > 0. I wanted to emphasize, that the port is never
> shown as 0 anymore. It is always some real port > 0.

Ah, I see. Sorry for the misunderstanding.

--
Serge Petrenko
sergepetrenko at tarantool.org



More information about the Tarantool-patches mailing list