[Tarantool-patches] [PATCH 1/1] iproto: show real port in logs and box.info.listen

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Mar 19 01:38:32 MSK 2020


Thanks for the review!

On 18/03/2020 19:18, Serge Petrenko wrote:
> Hi! Thanks for the patch!
> Alexander asked me to do the 2nd review.
> 
> The patch LGTM.
> 
> Sorry for nitpicking,  but looks like your changelog request has a typo in it:
>> @ChangeLog
>> - box.info.listen - new record in box.info <http://box.info>, which shows a
>>  real port when bound to port 0. For example, if box.cfg
>>  'listen' parameter was set to '127.0.0.1:0', box.info.listen
>>  will show '127.0.0.1:<real port > 0>' (gh-4620).
> just <real port>, without 0>, right?

Nope, I meant > 0. I wanted to emphasize, that the port is never
shown as 0 anymore. It is always some real port > 0.


More information about the Tarantool-patches mailing list