[Tarantool-patches] [PATCH v9 0/2] lua/log: add an ability to setup logger without box.cfg{}
Cyrill Gorcunov
gorcunov at gmail.com
Fri Jun 5 22:21:24 MSK 2020
On Fri, Jun 05, 2020 at 10:14:51PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patchset. I think this series should be pushed - LGTM.
> However I have several comments:
> - Don't forget to file an issue to rework approarch to module
> configuratoin and remove dead code (I suppose that functions
> private.cfg_set_log_level and private.cfg_set_log_format will be unused
> after that);
> - It would be nice to add tests from your previous series where you test
> possibility to pass string as log level.
Yes. I've a plan to address all this. Next week. Thanks!
More information about the Tarantool-patches
mailing list