[Tarantool-patches] [PATCH v9 0/2] lua/log: add an ability to setup logger without box.cfg{}

[Oleg Babin]

Hi! Thanks for your patchset. I think this series should be pushed - LGTM.
However I have several comments:
   - Don't forget to file an issue to rework approarch to module 
configuratoin and remove dead code (I suppose that functions 
private.cfg_set_log_level and private.cfg_set_log_format will be unused 
after that);
   - It would be nice to add tests from your previous series where you 
test possibility to pass string as log level.


On 05/06/2020 21:55, Cyrill Gorcunov wrote:
> In the series we add an ability to configure logger early without
> calling box.cfg{}. The syntax is the same as in box.cfg{} call.
> 
> There was an idea to implement something similar via triggers but
> I think this will require a way more efforts and code redesign,
> so at first lets stick to simplier solution.
> 
> I'm pretty sure we will be able to simplify and beautify code more later.
> 
> v9:
>   - complete reworking of the whole series
> 
> branch gorcunov/gh-689-logger-9
> issue https://github.com/tarantool/tarantool/issues/689
> 
> Cyrill Gorcunov (2):
>    lua/log: add ability to configure logging early
>    test: app-tap/logger -- test new modes
> 
>   src/box/lua/load_cfg.lua     |  65 ++++--
>   src/lua/log.lua              | 404 +++++++++++++++++++++++++++++++++--
>   test/app-tap/logger.test.lua |  83 ++++++-
>   test/box/reconfigure.result  |   2 +-
>   4 files changed, 512 insertions(+), 42 deletions(-)
>