[Tarantool-patches] [PATCH v6 00/25] Add static analysis with luacheck

[Igor Munkin]

Sasha,

On 01.06.20, Alexander Turenko wrote:
> On Mon, Jun 01, 2020 at 07:08:09PM +0200, Vladislav Shpilevoy wrote:
> > Hi!
> > 
> > Sorry, looks like this version also is not the final. Alexander T.
> > joined the review, and Igor still has comments. So I am going to
> > skip this one, and review the next version.
> 
> I just noted my objections against enabling redefinition warning by
> default. I asked this two times in March, but it was in a chat and it
> seems it was missed.
> 
> Also noted objection against removing unused arguments, when they show a
> function contract.
> 
> Nothing more. It is not full review and I hope I will not asked to do
> it.

Nevertheless, your comments might lead to a major change in the whole
patchset and are valuable since strictly saying we still don't have
definition of done criteria for this issue.

> 
> WBR, Alexander Turenko.

-- 
Best regards,
IM